Fix RVL depth decoding for non-quantized images #12289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxkitsune
added
🪳 bug
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in RVL depth decoding where zero disparity values were incorrectly treated as NaN for non-quantized (16UC1) images. The fix ensures that inverse quantization and zero-to-NaN conversion only apply to quantized (32FC1) images, while non-quantized values pass through unchanged.
Key Changes:
- Refactored
decode_rvl_with_quantizationto separate quantized and non-quantized code paths - Zero disparity values now only convert to NaN when quantization parameters are present
- Added comprehensive test coverage for non-quantized images with zero values
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
oxkitsune
added
the
consider-patch
Wumpf
approved these changes
Dec 19, 2025
Member
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
great catch. Thanks for handling it and adding a unit test!
ntjohnson1
pushed a commit
that referenced
this pull request
Dec 19, 2025
ntjohnson1
removed
the
consider-patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix RVL depth decoding to only apply inverse quantization when present.
Zero disparity is treated as NaN only for quantized (32FC1) images; non-quantized (16UC1) values now pass through unchanged.